Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace healpy with astropy-healpix and add new API to directly support SkyCoord objects #25

Merged
merged 17 commits into from
Apr 29, 2024
Merged

Replace healpy with astropy-healpix and add new API to directly support SkyCoord objects #25

merged 17 commits into from
Apr 29, 2024

Conversation

MetinSa
Copy link
Collaborator

@MetinSa MetinSa commented Apr 27, 2024 •
edited
Loading

This pull request implements the suggestions in #19, #20 and #23.

In addition, it will lead to a breaking change in the existing ZodiPy API. Although a new SkyCoord api get_emission_skycoord is introduced, the old functions like get_emission_pix and get_emission_ang still remain which support more healpy-like conventions in terms of the function arguments.

@MetinSa
Move solar_cut argument from the ZodiPy class to the binned function …
ce4ac11 
…signatures, as these really only make sense in that context (I think). Also, start the migration from healpy to astropy-healpix
@MetinSa
Use angular separation instead of cone search. Turns out healpix-cone…
0bf63f8 
… search is much slower than to just compute the angular separation between the pointing
@MetinSa
Add tests for skycoord api
b484d74
This was linked to issues Apr 27, 2024
Use astropy-healpix when projecting to HEALPIx #23
Closed
Allow users to use astropy SkyCoord objects directly in the public API #19
Closed
Use astropy SkyCoord to perform rotation between coordinate frames #20
Closed
@MetinSa MetinSa self-assigned this Apr 27, 2024
@MetinSa MetinSa added the enhancement New feature or request label Apr 27, 2024
@MetinSa
Copy link
Collaborator Author

MetinSa commented Apr 27, 2024

TODO: update usage docs page to use SkyCoords API for most usecases

@MetinSa
Copy link
Collaborator Author

MetinSa commented Apr 27, 2024 •
edited
Loading

Hi, @lpsinger! I am currently working on some of your suggestions from the pyOpenSci review and have a question regarding the frames used in the SkyCoord object for rotation purposes.

Conversion between coordinate frames is done using healpy.Rotator but could be done more simply and idiomatically with SkyCoord frame transformations.

Do you know which specific coordinate frame implementations would best correspond to the ["E", "G", "C"] used inhealpy.Rotator? I find that I am able to transform between BarycentricMeanEcliptic, Galactic and ICRS frames trivially, and it seems to reproduce the transformations I had before with healpy. The HeliocentricMeanEcliptic frame seems to be more difficult to use in the context of user provided pointing.

Perhaps you have some insight here too @pllim?

@pllim
Copy link
Contributor

pllim commented Apr 27, 2024

Re: Coordinate frames -- I am not an expert but perhaps @ayshih can advise or ping someone who can? 🙏

@MetinSa MetinSa changed the base branch from main to v1.0.0 April 29, 2024 15:45
@MetinSa MetinSa merged commit ca90047 into v1.0.0 Apr 29, 2024
8 checks passed
@MetinSa MetinSa deleted the astropy_healpix branch April 29, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MetinSa MetinSa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@MetinSa @pllim